1 Commits

Author SHA1 Message Date
zero@thinky e5724f0611 feat!(backend): unify script run and ad-hoc job run
ci-agent / build (push) Failing after 5m25s
2026-04-05 04:11:20 +03:00
6 changed files with 88 additions and 41 deletions
+28 -8
View File
@@ -1059,12 +1059,6 @@ const docTemplate = `{
"description": "Time period (e.g. 1h, 24h, 7d)",
"name": "period",
"in": "query"
},
{
"type": "string",
"description": "Filter by agent ID",
"name": "agent_id",
"in": "query"
}
],
"responses": {
@@ -1690,7 +1684,7 @@ const docTemplate = `{
"201": {
"description": "Created",
"schema": {
"$ref": "#/definitions/internal_handlers.JobResult"
"$ref": "#/definitions/internal_handlers.RunScriptOut"
}
},
"400": {
@@ -2124,7 +2118,7 @@ const docTemplate = `{
"201": {
"description": "Created",
"schema": {
"$ref": "#/definitions/internal_handlers.AddJobOut"
"$ref": "#/definitions/internal_handlers.RunScriptOut"
}
}
}
@@ -2910,6 +2904,32 @@ const docTemplate = `{
}
}
},
"internal_handlers.RunScriptOut": {
"type": "object",
"properties": {
"command": {
"type": "array",
"items": {
"type": "string"
}
},
"id": {
"type": "integer"
},
"status": {
"type": "integer"
},
"stderr": {
"type": "string"
},
"stdin": {
"type": "string"
},
"stdout": {
"type": "string"
}
}
},
"internal_handlers.RunStoredScriptIn": {
"type": "object",
"required": [
+28 -8
View File
@@ -1048,12 +1048,6 @@
"description": "Time period (e.g. 1h, 24h, 7d)",
"name": "period",
"in": "query"
},
{
"type": "string",
"description": "Filter by agent ID",
"name": "agent_id",
"in": "query"
}
],
"responses": {
@@ -1679,7 +1673,7 @@
"201": {
"description": "Created",
"schema": {
"$ref": "#/definitions/internal_handlers.JobResult"
"$ref": "#/definitions/internal_handlers.RunScriptOut"
}
},
"400": {
@@ -2113,7 +2107,7 @@
"201": {
"description": "Created",
"schema": {
"$ref": "#/definitions/internal_handlers.AddJobOut"
"$ref": "#/definitions/internal_handlers.RunScriptOut"
}
}
}
@@ -2899,6 +2893,32 @@
}
}
},
"internal_handlers.RunScriptOut": {
"type": "object",
"properties": {
"command": {
"type": "array",
"items": {
"type": "string"
}
},
"id": {
"type": "integer"
},
"status": {
"type": "integer"
},
"stderr": {
"type": "string"
},
"stdin": {
"type": "string"
},
"stdout": {
"type": "string"
}
}
},
"internal_handlers.RunStoredScriptIn": {
"type": "object",
"required": [
+19 -6
View File
@@ -504,6 +504,23 @@ definitions:
- interpreter_id
- script_text
type: object
internal_handlers.RunScriptOut:
properties:
command:
items:
type: string
type: array
id:
type: integer
status:
type: integer
stderr:
type: string
stdin:
type: string
stdout:
type: string
type: object
internal_handlers.RunStoredScriptIn:
properties:
stdin:
@@ -1229,10 +1246,6 @@ paths:
in: query
name: period
type: string
- description: Filter by agent ID
in: query
name: agent_id
type: string
produces:
- application/json
responses:
@@ -1595,7 +1608,7 @@ paths:
"201":
description: Created
schema:
$ref: '#/definitions/internal_handlers.JobResult'
$ref: '#/definitions/internal_handlers.RunScriptOut'
"400":
description: Bad Request
schema:
@@ -1869,7 +1882,7 @@ paths:
"201":
description: Created
schema:
$ref: '#/definitions/internal_handlers.AddJobOut'
$ref: '#/definitions/internal_handlers.RunScriptOut'
security:
- Bearer: []
summary: Run a script on an agent
+1 -3
View File
@@ -230,7 +230,6 @@ type JobMetricsOut struct {
// @Tags jobs
// @Produce json
// @Param period query string false "Time period (e.g. 1h, 24h, 7d)" default(24h)
// @Param agent_id query string false "Filter by agent ID"
// @Success 200 {object} JobMetricsOut
// @Failure 400 {object} map[string]string
// @Security Bearer
@@ -243,9 +242,8 @@ func (h *JobsHandlers) GetJobMetrics(c *gin.Context) {
return
}
agentID := c.Query("agent_id")
since := time.Now().Add(-period)
metrics, err := h.jobRepo.GetJobMetrics(c.Request.Context(), since, agentID)
metrics, err := h.jobRepo.GetJobMetrics(c.Request.Context(), since)
if err != nil {
c.Error(err)
return
+1 -1
View File
@@ -198,7 +198,7 @@ func (sh *ScriptHandlersGroup) DeleteScript(c *gin.Context) {
// @Produce json
// @Param id path int true "Script ID"
// @Param body body RunStoredScriptIn true "Agent token and optional stdin"
// @Success 201 {object} JobResult
// @Success 201 {object} RunScriptOut
// @Failure 400 {object} map[string]string
// @Failure 404 {object} map[string]string
// @Failure 500 {object} map[string]string
+11 -15
View File
@@ -113,22 +113,18 @@ type JobMetrics struct {
}
// GetJobMetrics returns job success metrics for jobs updated since the given time.
// If agentID is non-empty, results are filtered to that agent only.
func (r *JobRepository) GetJobMetrics(ctx context.Context, since time.Time, agentID string) (JobMetrics, error) {
// A successful job has status == 0, failed has status != 0, pending has status == 0 with empty stdout/stderr.
func (r *JobRepository) GetJobMetrics(ctx context.Context, since time.Time) (JobMetrics, error) {
var m JobMetrics
query := `SELECT
COUNT(*),
SUM(CASE WHEN status = 0 AND (stdout != '' OR stderr != '') THEN 1 ELSE 0 END),
SUM(CASE WHEN status != 0 THEN 1 ELSE 0 END),
SUM(CASE WHEN status = 0 AND stdout = '' AND stderr = '' THEN 1 ELSE 0 END)
FROM jobs WHERE updated_at >= ?`
args := []any{since}
if agentID != "" {
query += " AND agent_id = ?"
args = append(args, agentID)
}
err := r.DB.QueryRowContext(ctx, query, args...).Scan(&m.Total, &m.Success, &m.Failed, &m.Pending)
err := r.DB.QueryRowContext(ctx,
`SELECT
COUNT(*),
SUM(CASE WHEN status = 0 AND (stdout != '' OR stderr != '') THEN 1 ELSE 0 END),
SUM(CASE WHEN status != 0 THEN 1 ELSE 0 END),
SUM(CASE WHEN status = 0 AND stdout = '' AND stderr = '' THEN 1 ELSE 0 END)
FROM jobs WHERE updated_at >= ?`,
since,
).Scan(&m.Total, &m.Success, &m.Failed, &m.Pending)
if err != nil {
return JobMetrics{}, err
}