From a2268fda5dca15b26ba42063eb836c33f3c0ac75 Mon Sep 17 00:00:00 2001 From: "zero@thinky" Date: Sun, 15 Feb 2026 04:44:58 +0300 Subject: [PATCH] fix(cmd/fw): why to fucking log when it is printed by the only caller --- internal/blocker/firewalld.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/internal/blocker/firewalld.go b/internal/blocker/firewalld.go index a28506d..2a0ba1b 100644 --- a/internal/blocker/firewalld.go +++ b/internal/blocker/firewalld.go @@ -94,7 +94,6 @@ func (f *Firewalld) PortClose(port int, protocol string) error { // #nosec G204 - handle is extracted from nftables output and validated if port >= 0 && port <= 65535 { if protocol != "tcp" && protocol != "udp" { - f.logger.Error("invalid protocol") return fmt.Errorf("invalid protocol") } s := strconv.Itoa(port) @@ -106,13 +105,11 @@ func (f *Firewalld) PortClose(port int, protocol string) error { ) output, err := cmd.CombinedOutput() if err != nil { - f.logger.Error(err.Error()) return err } f.logger.Info("Remove port " + s + " " + string(output)) output, err = exec.Command("firewall-cmd", "--reload").CombinedOutput() if err != nil { - f.logger.Error(err.Error()) return err } f.logger.Info("Reload " + string(output))