fix: fix gosec and err checl
Some checks failed
build / build (push) Failing after 3m10s

This commit is contained in:
d3m0k1d
2026-01-21 22:30:27 +03:00
parent de000ab5b6
commit 211e019c68
4 changed files with 11 additions and 4 deletions

View File

@@ -55,6 +55,7 @@ var DaemonCmd = &cobra.Command{
ticker := time.NewTicker(5 * time.Second) ticker := time.NewTicker(5 * time.Second)
defer ticker.Stop() defer ticker.Stop()
for range ticker.C { for range ticker.C {
log.Info("TICK: ProcessUnviewed about to run")
if err := j.ProcessUnviewed(); err != nil { if err := j.ProcessUnviewed(); err != nil {
log.Error("Failed to process unviewed", "error", err) log.Error("Failed to process unviewed", "error", err)
} }

View File

@@ -39,11 +39,13 @@ func (j *Judge) LoadRules(rules []config.Rule) {
} }
func (j *Judge) ProcessUnviewed() error { func (j *Judge) ProcessUnviewed() error {
j.logger.Info("Processing unviewed logs")
rows, err := j.db.SearchUnViewed() rows, err := j.db.SearchUnViewed()
if err != nil { if err != nil {
j.logger.Error(fmt.Sprintf("Failed to query database: %v", err)) j.logger.Error(fmt.Sprintf("Failed to query database: %v", err))
return err return err
} }
j.logger.Info("Unviewed logs found")
defer func() { defer func() {
err = rows.Close() err = rows.Close()
if err != nil { if err != nil {
@@ -62,6 +64,7 @@ func (j *Judge) ProcessUnviewed() error {
&entry.IsViewed, &entry.IsViewed,
&entry.CreatedAt, &entry.CreatedAt,
) )
j.logger.Info("Scanning database row," + entry.IP)
if err != nil { if err != nil {
j.logger.Error(fmt.Sprintf("Failed to scan database row: %v", err)) j.logger.Error(fmt.Sprintf("Failed to scan database row: %v", err))
continue continue
@@ -101,7 +104,6 @@ func (j *Judge) ProcessUnviewed() error {
} }
} }
} }
err = j.db.MarkAsViewed(entry.ID) err = j.db.MarkAsViewed(entry.ID)
if err != nil { if err != nil {
j.logger.Error(fmt.Sprintf("Failed to mark entry as viewed: %v", err)) j.logger.Error(fmt.Sprintf("Failed to mark entry as viewed: %v", err))

View File

@@ -15,7 +15,7 @@ type Logger struct {
func New(debug bool) *Logger { func New(debug bool) *Logger {
logDir := "/var/log/banforge" logDir := "/var/log/banforge"
if err := os.MkdirAll(logDir, 0755); err != nil { if err := os.MkdirAll(logDir, 0750); err != nil {
return nil return nil
} }

View File

@@ -25,9 +25,13 @@ func Write(db *DB, resultCh <-chan *LogEntry) {
} }
stmt, err := tx.Prepare( stmt, err := tx.Prepare(
"INSERT INTO requests (service, ip, path, method, status, created_at) VALUES (?, ?, ?, ?, ?, ?)") "INSERT INTO requests (service, ip, path, method, status, created_at) VALUES (?, ?, ?, ?, ?, ?)",
)
if err != nil { if err != nil {
tx.Rollback() err := tx.Rollback()
if err != nil {
db.logger.Error("Failed to rollback transaction", "error", err)
}
db.logger.Error("Failed to prepare statement", "error", err) db.logger.Error("Failed to prepare statement", "error", err)
return return
} }